Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default to closeOnUnload unless we have some indication that a user may want to recover the connection #439

Closed
wants to merge 1 commit into from
Closed

default to closeOnUnload unless we have some indication that a user may want to recover the connection #439

wants to merge 1 commit into from

Conversation

SimonWoolf
Copy link
Member

@SimonWoolf SimonWoolf commented Dec 11, 2017 •
edited
Loading

Fixes #409

Bringing forward as we've had so many support tickets about this, and even though it's technically a breaking change, it's unlikely to affect anyone if we only apply it to people who don't use recover.

@paddybyers
Copy link
Member

LGTM, thanks

@SimonWoolf
Copy link
Member Author

Merged as 293aed1

@SimonWoolf SimonWoolf closed this Jan 30, 2018
@SimonWoolf SimonWoolf deleted the close-on-unload-true branch January 30, 2018 08:45
@SimonWoolf SimonWoolf mentioned this pull request Jan 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonWoolf @paddybyers